tanvipenumudy commented on code in PR #6706:
URL: https://github.com/apache/ozone/pull/6706#discussion_r1607886111
##########
hadoop-ozone/dist/src/main/smoketest/s3/commonawslib.robot:
##########
@@ -23,7 +23,9 @@ ${ENDPOINT_URL} http://s3g:9878
${OZONE_S3_HEADER_VERSION} v4
${OZONE_S3_SET_CREDENTIALS} true
${BUCKET} generated
+${BUCKET1} generated
${BUCKET_LAYOUT} OBJECT_STORE
+${BUCKET_LAYOUT1} FILE_SYSTEM_OPTIMIZED
Review Comment:
+1
##########
hadoop-ozone/dist/src/main/smoketest/s3/objectputget.robot:
##########
@@ -26,10 +26,11 @@ Suite Setup Setup s3 tests
${ENDPOINT_URL} http://s3g:9878
${OZONE_TEST} true
${BUCKET} generated
+${BUCKET1} generated
Review Comment:
Similarly, we can rename the instances of `${BUCKET}` and `${BUCKET1}` to
also include the layout type.
##########
hadoop-ozone/dist/src/main/smoketest/s3/objectputget.robot:
##########
@@ -241,3 +260,98 @@ Create key twice with different content and expect
different ETags
Execute AWSS3Cli rm
s3://${BUCKET}/test_key_to_check_etag_differences
Execute rm -rf /tmp/file1
Execute rm -rf /tmp/file2
+
+*** Test Cases ***
Review Comment:
I think we can loop (`FOR` - `END`) over the buckets `${BUCKET}`,
`${BUCKET1}` and type: OBS/FSO for reducing the redundancy under the individual
test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
