adoroszlai commented on code in PR #6718:
URL: https://github.com/apache/ozone/pull/6718#discussion_r1611037360
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java:
##########
@@ -299,6 +303,12 @@ void testOzoneFsServiceLoader() throws IOException {
OzoneConsts.OZONE_OFS_URI_SCHEME, confTestLoader),
RootedOzoneFileSystem.class);
}
+ @Test
+ void testUserHomeDirectory() {
+ assertEquals(new Path("/user/" + USER1), userOfs.getHomeDirectory());
+ assertEquals(new Path("/user/" + USER1), userO3fs.getHomeDirectory());
Review Comment:
Please add test for O3FS to `AbstractOzoneFileSystem` instead.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java:
##########
@@ -279,6 +280,9 @@ void initClusterAndEnv() throws IOException,
InterruptedException, TimeoutExcept
userOfs = UGI_USER1.doAs(
(PrivilegedExceptionAction<RootedOzoneFileSystem>)()
-> (RootedOzoneFileSystem) FileSystem.get(conf));
+ userO3fs = UGI_USER1.doAs(
+ (PrivilegedExceptionAction<OzoneFileSystem>)()
+ -> (OzoneFileSystem) FileSystem.get(conf));
Review Comment:
How does this work? I would expect `FileSystem.get(conf)` to return the
same implementation (even same instance if cache is not disabled) for both
calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
