errose28 commented on code in PR #6506:
URL: https://github.com/apache/ozone/pull/6506#discussion_r1617916838
##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -96,5 +96,36 @@ Cannot close container without admin privilege
Cannot create container without admin privilege
Requires admin privilege ozone admin container create
+Cannot reconcile container without admin privilege
+ Requires admin privilege ozone admin container reconcile "${CONTAINER}"
+
Reset user
Run Keyword if '${SECURITY_ENABLED}' == 'true' Kinit test user
testuser testuser.keytab
+
+Cannot reconcile open container
+ # At this point we should have an open Ratis Three container.
+ ${container} = Execute ozone admin container list --state
OPEN | jq -r 'select(.replicationConfig.replicationFactor == "THREE") |
.containerID' | head -n1
+ Execute and check rc ozone admin container reconcile "${container}"
255
+ # The container should not yet have any replica checksums.
+ # TODO When the scanner is computing checksums automatically, this test
may need to be updated.
+ ${data_checksum} = Execute ozone admin container info
"${container}" --json | jq -r '.replicas[].dataChecksum' | head -n1
+ # 0 is the hex value of an empty checksum.
+ Should Be Equal As Strings 0 ${data_checksum}
+
+Close container
+ ${container} = Execute ozone admin container list --state
OPEN | jq -r 'select(.replicationConfig.replicationFactor == "THREE") |
.containerID' | head -1
+ Execute ozone admin container close
"${container}"
+ ${output} = Execute ozone admin container info
"${container}"
+ Should contain ${output} CLOS
Review Comment:
`CLOS` is used here (and in the existing `close container` test) because the
state may either be `CLOSING` or `CLOSED` between when the container close
command finishes and the container info command is executed. After this, we
wait until the final state finishes moving to CLOSED. I can add a comment
explaining this.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/reconciliation/package-info.java:
##########
@@ -0,0 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.hdds.scm.container.reconiliation;
Review Comment:
oh good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
