adoroszlai commented on PR #6747: URL: https://github.com/apache/ozone/pull/6747#issuecomment-2138834684
Thanks @errose28 for the review. > * The tests run for both ratis and non-ratis cases (in `TestOzoneRpcClientAbstract`) and those run only for Ratis cases (in `TestOzoneRpcClientWithRatis`) seem kind of arbitrary. > > * Maybe we can either unify them so all tests run in both setups, or only a minimal amount of validation is done in the non-ratis setup. > * Also tests that are unique to `TestOzoneRpcClientWithRatis` are not run in a secure setup. Agree, we should move them to the parent class. > * `TestSecureOzoneRpcClient` extends `TestOzoneRpcClient`, so now the secure tests are only running in a non-ratis OM setup. This is not the case, since `TestSecureOzoneRpcClient` creates its own cluster, `TestOzoneRpcClient#init` is not invoked due to "shadowing" (which is a bit obscure). Otherwise it would be testing an unsecure setup or starting two clusters. This should be improved, too. Will push a few more commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
