ChenSammi commented on code in PR #6731:
URL: https://github.com/apache/ozone/pull/6731#discussion_r1634973361
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -418,16 +464,22 @@ public List<DeleteBlockTransactionResult>
executeCmdWithRetry(
transactions.forEach(tx -> idToTransaction.put(tx.getTxID(), tx));
List<DeletedBlocksTransaction> retryTransaction = new ArrayList<>();
+ List<DeletedBlocksTransaction> filteredTxs =
filterDuplicateTxs(transactions, results);
List<Future<DeleteBlockTransactionExecutionResult>> futures =
- submitTasks(transactions);
+ submitTasks(filteredTxs);
// Wait for tasks to finish
+ List<Long> committedTransactionIDs = new ArrayList<>();
handleTasksResults(futures, result -> {
if (result.isLockAcquisitionFailed()) {
retryTransaction.add(idToTransaction.get(result.getResult().getTxID()));
} else {
+ if (result.getResult().getSuccess()) {
+ committedTransactionIDs.add(result.getResult().getTxID());
Review Comment:
Can we directly add the ID into committedTransactionCache here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
