fapifta commented on code in PR #6802:
URL: https://github.com/apache/ozone/pull/6802#discussion_r1637290752
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -451,6 +452,7 @@ public static String
getDatanodeIdFilePath(ConfigurationSource conf) {
*/
public static SCMSecurityProtocolClientSideTranslatorPB getScmSecurityClient(
ConfigurationSource conf) throws IOException {
+ new SecurityConfig(conf);
Review Comment:
Yes, unfortunately yes.
I am not the fan of this scattered solution either, but different
initialization paths may or may not create a SecurityConfig object, this way we
ensure that the BouncyCastle JCE provider is loaded programmatically, so we can
use it to convert between PEM files and Certificates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
