smengcl commented on PR #6014: URL: https://github.com/apache/ozone/pull/6014#issuecomment-2166927131
I brought test failures back down to the last one of them: [`TestOzoneClientRetriesOnExceptions.testMaxRetriesByOzoneClient`](https://github.com/apache/ozone/actions/runs/9494639197/job/26165931945?pr=6014#step:5:2287). `testMaxRetriesByOzoneClient` [expects](https://github.com/apache/ozone/blob/e93e781ffc991571cbd335e338f4d5a8fbe4a223/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneClientRetriesOnExceptions.java#L235-L246) `key.write()` to throw IOException after maximum retries after all the containers of the key is closed. The expected IOException message looks like this (got this on HDDS-7593 branch where the test is passing): ``` java.io.IOException: java.io.IOException: java.io.IOException: java.io.IOException: java.io.IOException: Retry request failed. retries get failed due to exceeded maximum allowed retries number: 3 ``` (Looks like the `IOException` was wrapped 5 times.) While in this PR, the same test is failing because it is no longer throwing `IOException` with the same `key.write()`. I suspect watchForCommit() was responsible for composing the `IOException` from `ContainerNotOpenException`s after a number of retries. But now that watchForCommit() is (mostly) gone, this code path is no longer active and causes this change in behavior. (`ContainerNotOpenException` is still thrown though.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
