devmadhuu commented on code in PR #6679:
URL: https://github.com/apache/ozone/pull/6679#discussion_r1639856522
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java:
##########
@@ -326,8 +326,11 @@ private void setKeyParentID(OmKeyInfo keyInfo) throws
IOException {
if (parentKeyInfo != null) {
keyInfo.setParentObjectID(parentKeyInfo.getObjectID());
} else {
- throw new IOException("ParentKeyInfo for " +
- "NSSummaryTaskWithLegacy is null");
+ LOG.error(
Review Comment:
Pls change it to warn level. This may not be error as Recon OM DB can go out
of sync with OM DB, so we need to first make sure with elaborative warn log.
Ideally parent object Id for a key should not be null, so we need to find if
this is the same case with OM DB as well.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java:
##########
@@ -349,8 +352,11 @@ private void setParentBucketId(OmKeyInfo keyInfo)
if (parentBucketInfo != null) {
keyInfo.setParentObjectID(parentBucketInfo.getObjectID());
} else {
- throw new IOException("ParentKeyInfo for " +
- "NSSummaryTaskWithLegacy is null");
+ LOG.error(
Review Comment:
Pls change it to warn level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
