fapifta commented on code in PR #6770: URL: https://github.com/apache/ozone/pull/6770#discussion_r1645154067
########## hadoop-hdds/crypto-default/pom.xml: ########## @@ -0,0 +1,37 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.ozone</groupId> + <artifactId>hdds</artifactId> + <version>1.5.0-SNAPSHOT</version> + </parent> + + <artifactId>hdds-crypto-default</artifactId> Review Comment: Thank you for remaining engaged on this review @adoroszlai, after doing the change, I also had a feeling that I don't particularly in fond of this name, however I was curious what do you think. Now, after we ran a circle... I started to hesitate, and I am somewhere in between the `-interface` and the `-api` suffix, slightly on the side of `-api`. Let me explain how my mind plays tricks with me and changes direction after every comment you make. The first thought of using `-interface` was a bit mindless, and after checking the project to do the rename, I realized that it is a prefix not a suffix in other modules. As a prefix looking at the `interface-*` modules' contents, my understanding is that, we express that a module defines a protocol/interface between services and clients, and in light of this realization I started to change my mind about the `interface` as a prefix for hdds-crypto. Now that you are also expressing the same feeling, and suggest to use it as a suffix instead, I feel that using `-interface` as a suffix would overload this meaning, that is why I turn back towards the `-api` suffix, as it seems to be more appropriate to do not overload the meaning of `interface`. So all in all, what if we go back to your initial suggestion and use `-api`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
