[
https://issues.apache.org/jira/browse/HDDS-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-11031:
----------------------------------
Labels: pull-request-available (was: )
> Merge BaseApprover abstract class with the DefaultApprover
> ----------------------------------------------------------
>
> Key: HDDS-11031
> URL: https://issues.apache.org/jira/browse/HDDS-11031
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: István Fajth
> Assignee: István Fajth
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Currently we have 3 types defined for approving Certificate Sign Requests:
> - CertificateApprover (the base interface)
> - BaseApprover (an abstract implementation)
> - DefaultApprover (the actual implementation)
> Separating an abstract class is speculative before we have more than one
> implementation, also scatters the code to different places without any
> meaningful gain coming from the fact that we have an abstract class.
> As part of this change, the goal is to merge the abstract class with the
> DefaultApprover, and then simplify and clean up the code, in a way that the
> CertificateApprover interface does not have any BouncyCastle dependencies,
> and all BouncyCastle dependencies are encapsulated within the DefaultApprover
> class as a first step.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
