adoroszlai commented on code in PR #6883:
URL: https://github.com/apache/ozone/pull/6883#discussion_r1669168985
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java:
##########
@@ -281,8 +281,7 @@ public DatanodeStateMachine(DatanodeDetails datanodeDetails,
private int getEndPointTaskThreadPoolSize() {
// TODO(runzhiwang): current only support one recon, if support multiple
// recon in future reconServerCount should be the real number of recon
- int reconServerCount = 1;
- int totalServerCount = reconServerCount;
Review Comment:
The comment mentions `reconServerCount`. If you remove that variable,
please adjust the comment accordingly.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java:
##########
@@ -625,9 +621,9 @@ public synchronized void stopDaemon() {
context.setState(DatanodeStates.SHUTDOWN);
reportManager.shutdown();
this.close();
- LOG.info("Ozone container server stopped.");
+ LOG.info("The DatanodeStateMachine stopped.");
} catch (IOException e) {
- LOG.error("Stop ozone container server failed.", e);
+ LOG.error("Stop DatanodeStateMachine failed.", e);
Review Comment:
`DatanodeStateMachine` is included in the log as part of the class where the
message is being logged. I'd prefer to keep the current wording. Also adjust
the new message above about "starting".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
