Tejaskriya commented on PR #6914: URL: https://github.com/apache/ozone/pull/6914#issuecomment-2219839011
> The current approach looks good and I'm okay if we go with it, but since we use proto for encoding and decoding , we could also leverage protobuf's [getDescriptor](https://protobuf.dev/reference/java/api-docs/com/google/protobuf/Descriptors) to print the schema . Something like this would print 1 level of schema for the message, All we have to do is find the proto object for each valueType. We probably would need to define toProtoBuf() method for each message type to convert to proto which would be extra work. Please check if this is easier or else the current patch looks good. With this approach, one major issue was that the field names were different from what is seen when we do a `ozone debug ldb scan` command on a table. That is due to the variable name difference in proto message definition and the java class. For example, in the volumeTable, in `scan` we see it as "acls" but the proto message is "volumeacls". The current approach seems to be simpler IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
