hemantk-12 commented on code in PR #6920:
URL: https://github.com/apache/ozone/pull/6920#discussion_r1673037249
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java:
##########
@@ -63,7 +63,10 @@ public class SnapshotDiffHandler extends Handler {
@CommandLine.Option(names = {"-p", "--page-size"},
description = "number of diff entries to be returned in the response" +
- " (optional)")
+ " (optional)",
Review Comment:
nit:
1. remove `(optional)` similar to length in
[ListOptions](https://github.com/apache/ozone/blob/f9ec90c4002ddb68d3cb89e88c0d7c48d99979e3/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/ListOptions.java#L32).
2. 1000 is also maxed page size allowed
[here](https://github.com/apache/ozone/blob/5dcdf85c7aca22cea8f39a64888e6519f1a5b2bb/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java#L740),
we should add this in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
