tanvipenumudy commented on code in PR #6321:
URL: https://github.com/apache/ozone/pull/6321#discussion_r1673773833
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java:
##########
@@ -159,13 +167,15 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
try {
// check Acl
+ long startNanosDeleteKeysAclCheckLatency = Time.monotonicNowNanos();
checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
- IAccessAuthorizer.ACLType.DELETE, OzoneObj.ResourceType.KEY,
- volumeOwner);
+ IAccessAuthorizer.ACLType.DELETE, OzoneObj.ResourceType.KEY,
+ volumeOwner);
OzoneFileStatus fileStatus = getOzoneKeyStatus(
ozoneManager, omMetadataManager, volumeName, bucketName,
keyName);
addKeyToAppropriateList(omKeyInfoList, omKeyInfo, dirList,
fileStatus);
+ perfMetrics.setDeleteKeysAclCheckLatencyNs(Time.monotonicNowNanos()
- startNanosDeleteKeysAclCheckLatency);
Review Comment:
Do you think we should be repositioning the line where we're updating
`deleteKeysAclCheckLatencyNs` right after the `checkKeyAcls` call (similar to
`deleteKeysResolveBucketLatencyNs`)?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java:
##########
@@ -159,13 +167,15 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
try {
// check Acl
+ long startNanosDeleteKeysAclCheckLatency = Time.monotonicNowNanos();
checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
- IAccessAuthorizer.ACLType.DELETE, OzoneObj.ResourceType.KEY,
- volumeOwner);
+ IAccessAuthorizer.ACLType.DELETE, OzoneObj.ResourceType.KEY,
+ volumeOwner);
Review Comment:
Minor nit: Unintended indent
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java:
##########
@@ -198,7 +204,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
omClientResponse.setOmLockDetails(getOmLockDetails());
}
}
-
Review Comment:
Minor nit: Unintended new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
