adoroszlai commented on code in PR #6922:
URL: https://github.com/apache/ozone/pull/6922#discussion_r1676161266
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java:
##########
@@ -287,13 +288,17 @@ private boolean bucketContainsSnapshotInCache(
)
public static OMRequest blockBucketDeleteWithBucketLayoutFromOldClient(
OMRequest req, ValidationContext ctx) throws IOException {
- DeleteBucketRequest request = req.getDeleteBucketRequest();
-
- if (request.hasBucketName() && request.hasVolumeName()) {
- BucketLayout bucketLayout = ctx.getBucketLayout(
- request.getVolumeName(), request.getBucketName());
- bucketLayout.validateSupportedOperation();
+ if (ClientVersion.fromProtoValue(req.getVersion())
+ .compareTo(ClientVersion.BUCKET_LAYOUT_SUPPORT) < 0) {
+ DeleteBucketRequest request = req.getDeleteBucketRequest();
+
+ if (request.hasBucketName() && request.hasVolumeName()) {
+ BucketLayout bucketLayout = ctx.getBucketLayout(
+ request.getVolumeName(), request.getBucketName());
+ bucketLayout.validateSupportedOperation();
+ }
}
return req;
Review Comment:
I'd suggest:
```java
ClientVersion.BUCKET_LAYOUT_SUPPORT.isSupportedByClient(req.getVersion())
```
(which also highlights why "SUPPORT" shouldn't be part of the enum constant
name...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
