smengcl commented on code in PR #6859:
URL: https://github.com/apache/ozone/pull/6859#discussion_r1676429334
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -112,8 +112,11 @@ public class BlockOutputStream extends OutputStream {
private final AtomicReference<IOException> ioException;
private final ExecutorService responseExecutor;
- // the effective length of data flushed so far
- private long totalDataFlushedLength;
+ // the effective length of data sent to datanodes (via writeChunk).
+ private long totalSyncedDataLength;
+
+ // The effective length of data flushed to datanodes (via putBlock).
+ private long totalFlushedDataLength;
Review Comment:
Not sure `Synced` and `Flushed` are the best modifier to differentiate both.
Maybe just call them
`totalWriteChunkDataLength`
`totalPutBlockDataLength`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
