dombizita commented on code in PR #6842:
URL: https://github.com/apache/ozone/pull/6842#discussion_r1655043855
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/CertificateClient.java:
##########
@@ -155,13 +156,12 @@ boolean verifySignature(byte[] data, byte[] signature,
X509Certificate cert) throws CertificateException;
/**
- * Returns a CSR builder that can be used to create a Certificate sigining
- * request.
+ * Returns a CertificateSignRequest object, that can be used to retrieve
+ * a signed certificate from our CA server implementation.
*
- * @return CertificateSignRequest.Builder
+ * @return CertificateSignRequest a CSR based on which the certificate can
be issued.
*/
- CertificateSignRequest.Builder getCSRBuilder()
- throws CertificateException;
+ CertificateSignRequest.Builder configureCSRBuilder() throws
SCMSecurityException;
Review Comment:
I believe we are still returning a `CertificateSignRequest.Builder`, right?
With these changes the only thing that changed is that if you call `build()` on
this builder it'll return a `CertificateSignRequest`. I'm asking these because
of the javadoc changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
