adoroszlai commented on code in PR #6886:
URL: https://github.com/apache/ozone/pull/6886#discussion_r1681086369
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/DatanodeState.java:
##########
@@ -55,4 +55,9 @@ public interface DatanodeState<T> {
T await(long time, TimeUnit timeUnit)
throws InterruptedException, ExecutionException, TimeoutException;
+ /**
+ * Clean up some resources.
+ */
+ void clear();
Review Comment:
Please add default no-op implementation.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/datanode/InitDatanodeState.java:
##########
@@ -178,4 +178,9 @@ public DatanodeStateMachine.DatanodeStates await(long time,
ExecutionException, TimeoutException {
return result.get(time, timeUnit);
}
+
+ @Override
+ public void clear() {
+
+ }
Review Comment:
No change needed in this file after adding default no-op implementation.
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestStateContext.java:
##########
@@ -542,6 +542,11 @@ public DatanodeStates await(long time, TimeUnit timeUnit)
10000);
return DatanodeStates.RUNNING;
}
+
+ @Override
+ public void clear() {
+
+ }
Review Comment:
No change needed in this file after adding default no-op implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
