errose28 commented on PR #97: URL: https://github.com/apache/ozone-site/pull/97#issuecomment-2246359621
Thanks for working on this @will-sh. I tried it out and it seems to work well. Just a few suggestions: - IMO the icons look better on the left side than the right. This way they all align in a column. - We can remove the css tags in the SVG files that are left over from where we copied them since we aren't using them. - I *think* defining the sizes using `em` for font units instead of pixels is better since the icons are aligned with text, but I don't have a lot of experience here so maybe there is a drawback to doing it this way. I tried out these changes by adding a few commits on top of this PR [here](https://github.com/errose28/ozone-site/pull/new/footer-icons-on-pr). The result looks like this:  If these changes look good we can commit something similar here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
