kerneltime commented on code in PR #6987:
URL: https://github.com/apache/ozone/pull/6987#discussion_r1691988426
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -623,6 +639,35 @@ public boolean syncDataFromOM() {
return true;
}
+ private void printFileAndKeyTableCount() throws IOException {
Review Comment:
This method has different handling for `fileTable` and `keyTable`, the
reason for this is not obvious. We return if `keyTable` is null even if
`fileTable` might not be. This is making business logic assumptions for OM? Why
not write this in a manner that does not assume which table can or cannot be
`null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
