ivandika3 commented on code in PR #6982:
URL: https://github.com/apache/ozone/pull/6982#discussion_r1692363731


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1815,7 +1814,7 @@ public List<ExpiredMultipartUploadsBucket> 
getExpiredMultipartUploads(
              mpuInfoTableIterator = getMultipartInfoTable().iterator()) {
 
       final long expiredCreationTimestamp =
-          Instant.now().minus(expireThreshold).toEpochMilli();
+          expireThreshold.negated().plusMillis(Time.now()).toMillis();

Review Comment:
   Thank you for the review. I agree with switching from `Time.now()` to 
`Instant.now()` (which will be addressed in HDDS-7911). However, currently the 
issue is that `OmKeyInfo` `creationTimestamp` and `modificationTimestamp`  
already using `Time.now()`. If we switch to `Instant.now()` instead, the 
timestamps in the key / file table will be a mix of UTC and local time zone.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to