ivandika3 commented on code in PR #6977:
URL: https://github.com/apache/ozone/pull/6977#discussion_r1691213474
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManagerMXBean.java:
##########
@@ -48,4 +49,8 @@ public interface NodeManagerMXBean {
*/
Map<String, Map<String, String>> getNodeStatusInfo();
+ default Map<String, String> getNodeStatics() {
Review Comment:
Typo: `Statics` -> `Statistics`.
Also applies to other instances of `Statics` in the patch.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1284,6 +1326,20 @@ public String getLabel() {
}
}
+ private enum UsageStatics {
+ MIN("Min"),
+ MAX("Max"),
+ MEDINNA("Medina"),
Review Comment:
Typo: `MEDINA` -> `MEDIAN`. Also applies to similar typos.
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -28,6 +28,16 @@ <h2>SCM Information</h2>
</tbody>
</table>
+<h2>Statistical</h2>
+<table class="table table-bordered table-striped">
+ <tbody>
+ <tr>
+ <td>DataNodes usages% (Min/Median/Max/stdDev)</td>
+
<td>{{statistical.usages.min}}%/{{statistical.usages.medina}}%/{{statistical.usages.max}}%/{{statistical.usages.stdev}}%</td>
+ </tr>
+ </tbody>
Review Comment:
I think it will be better to have separate column for each statistic.
Something like:
| | Min | Median | Max | Std Dev
|
| ------------- | ------- | ----------- | ------- | -------- |
| Datanode Storage Used | 10% | 30% | 70% | 20% |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
