aswinshakil commented on code in PR #6945:
URL: https://github.com/apache/ozone/pull/6945#discussion_r1692797382


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -156,6 +159,8 @@ public KeyValueHandler(ConfigurationSource config,
         DatanodeConfiguration.class).isChunkDataValidationCheck();
     chunkManager = ChunkManagerFactory.createChunkManager(config, blockManager,
         volSet);
+    checksumManager = new ContainerChecksumTreeManager(
+        config.getObject(DatanodeConfiguration.class));

Review Comment:
   One problem I see is that `handleGetContainerMerkleTree` requires checksum 
manager. We need to either move this or add checksum manager to 
`KeyValueHandler` again it would lead to more number of file changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to