[
https://issues.apache.org/jira/browse/HDDS-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddhant Sangwan updated HDDS-11247:
------------------------------------
Description:
TestContainerReportHandling and TestContainerReportHandlingWithHA are
integration tests. They're related to each other and should ideally be present
in the same file. However for reasons that are not clear yet, having them in
the same file makes the non-HA test case fail with:
{code}
2024-07-26 11:50:20,864 [main] WARN ha.SCMHANodeDetails
(SCMHANodeDetails.java:validateSCMHAConfig(180)) - Default/Configured value of
config ozone.scm.ratis.enable conflicts with the expected value.
Default/Configured: true. Expected: false. Falling back to the expected value.
Current State of SCM: SCM is running without Ratis. Ratis SCM -> Non Ratis SCM
is not supported.
org.apache.hadoop.hdds.conf.ConfigurationException: Setting conflicting Default
Configs old default Value: true New Default Value:false
at
org.apache.hadoop.hdds.conf.DefaultConfigManager.setConfigValue(DefaultConfigManager.java:40)
at
org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.validateSCMHAConfig(SCMHANodeDetails.java:189)
at
org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.loadSCMHAConfig(SCMHANodeDetails.java:208)
at
org.apache.hadoop.hdds.scm.server.StorageContainerManager.<init>(StorageContainerManager.java:368)
at
org.apache.hadoop.hdds.scm.server.StorageContainerManager.createSCM(StorageContainerManager.java:616)
at
org.apache.hadoop.hdds.scm.HddsTestUtils.getScmSimple(HddsTestUtils.java:588)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createSCM(MiniOzoneClusterImpl.java:625)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createAndStartSingleSCM(MiniOzoneClusterImpl.java:608)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.build(MiniOzoneClusterImpl.java:534)
at
org.apache.hadoop.ozone.container.TestContainerReportHandling.newCluster(TestContainerReportHandling.java:179)
at
org.apache.hadoop.ozone.container.TestContainerReportHandling.testDeletingContainerTransitionsToClosedWhenNonEmptyReplicaIsReported(TestContainerReportHandling.java:82)
at java.lang.reflect.Method.invoke(Method.java:498)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at java.util.ArrayList.forEach(ArrayList.java:1259)
{code}
It's something to do with the scm version file.
This jira is to investigate this issue. We can also delete the logic that
explicitly cleans up mini ozone cluster tests dirs and resources (cluster
shutdown should already handle that).
It's also possible that a separate test case for non-HA isn't needed and the HA
test case covers it, but I think it's better to have different, explicit tests
for all cases.
was:
TestContainerReportHandling and TestContainerReportHandlingWithHA are
integration tests. They're related to each other and should ideally be present
in the same file. However for reasons that are not clear yet, having them in
the same file makes the non-HA test case fail with:
{code}
2024-07-26 11:50:20,864 [main] WARN ha.SCMHANodeDetails
(SCMHANodeDetails.java:validateSCMHAConfig(180)) - Default/Configured value of
config ozone.scm.ratis.enable conflicts with the expected value.
Default/Configured: true. Expected: false. Falling back to the expected value.
Current State of SCM: SCM is running without Ratis. Ratis SCM -> Non Ratis SCM
is not supported.
org.apache.hadoop.hdds.conf.ConfigurationException: Setting conflicting Default
Configs old default Value: true New Default Value:false
at
org.apache.hadoop.hdds.conf.DefaultConfigManager.setConfigValue(DefaultConfigManager.java:40)
at
org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.validateSCMHAConfig(SCMHANodeDetails.java:189)
at
org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.loadSCMHAConfig(SCMHANodeDetails.java:208)
at
org.apache.hadoop.hdds.scm.server.StorageContainerManager.<init>(StorageContainerManager.java:368)
at
org.apache.hadoop.hdds.scm.server.StorageContainerManager.createSCM(StorageContainerManager.java:616)
at
org.apache.hadoop.hdds.scm.HddsTestUtils.getScmSimple(HddsTestUtils.java:588)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createSCM(MiniOzoneClusterImpl.java:625)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createAndStartSingleSCM(MiniOzoneClusterImpl.java:608)
at
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.build(MiniOzoneClusterImpl.java:534)
at
org.apache.hadoop.ozone.container.TestContainerReportHandling.newCluster(TestContainerReportHandling.java:179)
at
org.apache.hadoop.ozone.container.TestContainerReportHandling.testDeletingContainerTransitionsToClosedWhenNonEmptyReplicaIsReported(TestContainerReportHandling.java:82)
at java.lang.reflect.Method.invoke(Method.java:498)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at java.util.ArrayList.forEach(ArrayList.java:1259)
{code}
This jira is to investigate this issue. We can also delete the logic that
explicitly cleans up mini ozone cluster tests dirs and resources (cluster
shutdown should already handle that).
It's also possible that a separate test case for non-HA isn't needed and the HA
test case covers it, but I think it's better to have different, explicit tests
for all cases.
> Clean up TestContainerReportHandling
> ------------------------------------
>
> Key: HDDS-11247
> URL: https://issues.apache.org/jira/browse/HDDS-11247
> Project: Apache Ozone
> Issue Type: Bug
> Components: test
> Reporter: Siddhant Sangwan
> Priority: Major
>
> TestContainerReportHandling and TestContainerReportHandlingWithHA are
> integration tests. They're related to each other and should ideally be
> present in the same file. However for reasons that are not clear yet, having
> them in the same file makes the non-HA test case fail with:
> {code}
> 2024-07-26 11:50:20,864 [main] WARN ha.SCMHANodeDetails
> (SCMHANodeDetails.java:validateSCMHAConfig(180)) - Default/Configured value
> of config ozone.scm.ratis.enable conflicts with the expected value.
> Default/Configured: true. Expected: false. Falling back to the expected
> value. Current State of SCM: SCM is running without Ratis. Ratis SCM -> Non
> Ratis SCM is not supported.
> org.apache.hadoop.hdds.conf.ConfigurationException: Setting conflicting
> Default Configs old default Value: true New Default Value:false
> at
> org.apache.hadoop.hdds.conf.DefaultConfigManager.setConfigValue(DefaultConfigManager.java:40)
> at
> org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.validateSCMHAConfig(SCMHANodeDetails.java:189)
> at
> org.apache.hadoop.hdds.scm.ha.SCMHANodeDetails.loadSCMHAConfig(SCMHANodeDetails.java:208)
> at
> org.apache.hadoop.hdds.scm.server.StorageContainerManager.<init>(StorageContainerManager.java:368)
> at
> org.apache.hadoop.hdds.scm.server.StorageContainerManager.createSCM(StorageContainerManager.java:616)
> at
> org.apache.hadoop.hdds.scm.HddsTestUtils.getScmSimple(HddsTestUtils.java:588)
> at
> org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createSCM(MiniOzoneClusterImpl.java:625)
> at
> org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createAndStartSingleSCM(MiniOzoneClusterImpl.java:608)
> at
> org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.build(MiniOzoneClusterImpl.java:534)
> at
> org.apache.hadoop.ozone.container.TestContainerReportHandling.newCluster(TestContainerReportHandling.java:179)
> at
> org.apache.hadoop.ozone.container.TestContainerReportHandling.testDeletingContainerTransitionsToClosedWhenNonEmptyReplicaIsReported(TestContainerReportHandling.java:82)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at java.util.ArrayList.forEach(ArrayList.java:1259)
> at java.util.ArrayList.forEach(ArrayList.java:1259)
> {code}
> It's something to do with the scm version file.
> This jira is to investigate this issue. We can also delete the logic that
> explicitly cleans up mini ozone cluster tests dirs and resources (cluster
> shutdown should already handle that).
> It's also possible that a separate test case for non-HA isn't needed and the
> HA test case covers it, but I think it's better to have different, explicit
> tests for all cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
