sadanand48 commented on code in PR #6993:
URL: https://github.com/apache/ozone/pull/6993#discussion_r1695210909
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -642,4 +655,13 @@ public void awaitDoubleBufferFlush() throws
InterruptedException {
public OzoneManagerDoubleBuffer getOzoneManagerDoubleBuffer() {
return ozoneManagerDoubleBuffer;
}
+
+ private Set<String> getSplitRequestIgnoreFailure() {
Review Comment:
Something like this could be more readable?
```java
boolean canRequestFailureBeIgnored(RequestType type)
```
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4429,4 +4429,13 @@
maximum number of buckets across all volumes.
</description>
</property>
+ <property>
+ <name>ozone.om.requests.ignore.terminate.on.failure</name>
+ <value>DeleteOpenKeys,EchoRPC</value>
Review Comment:
DeleteOpenKeys alters the openKeyTable cache inside the request. I feel any
request that alters the state of OM (say cache/DB) should not come under this
category as ignoring such failures might cause inconsistency in OM metadata
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4429,4 +4429,13 @@
maximum number of buckets across all volumes.
</description>
</property>
+ <property>
+ <name>ozone.om.requests.ignore.terminate.on.failure</name>
Review Comment:
Should we provide this as a config or use it as a constant in code itself.
Misuse of this property could be dangerous and lead to consistent state. By
providing a config, the user/admin has control over internal behaviour of OM.
IMO we should not provide such a config as providing such options will be more
prone to problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
