devabhishekpal commented on code in PR #6724:
URL: https://github.com/apache/ozone/pull/6724#discussion_r1686231017
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -389,24 +398,36 @@ export class Datanodes extends
React.Component<Record<string, object>, IDatanode
return selectedColumns;
};
- _loadData = () => {
- this.setState(prevState => ({
- loading: true,
- selectedColumns: this._getSelectedColumns(prevState.selectedColumns)
- }));
-
- const { request, controller } = AxiosGetHelper('/api/v1/datanodes',
cancelSignal);
- cancelSignal = controller;
- request.then(response => {
- const datanodesResponse: IDatanodesResponse = response.data;
+ _loadData = async () => {
+ // Need to call decommission API on each interval to get updated status
before datanode API to compare UUID's
+ // update Operation State Column in table Manually before rendering
+ try {
+ let decomissionResponse = await this._loadDecommisionAPI();
+ decommissionUuids = decomissionResponse && decomissionResponse.data &&
+ decomissionResponse.data.DatanodesDecommissionInfo &&
+ decomissionResponse.data.DatanodesDecommissionInfo.map((item: {
datanodeDetails: { uuid: any; }; }) => item.datanodeDetails.uuid);
Review Comment:
Just a nit to use optional chaining
```suggestion
decommissionUuids =
decomissionResponse.data?.DatanodesDecommissionInfo?.map((item: {
datanodeDetails: { uuid: any; }; }) => item.datanodeDetails.uuid);
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -389,24 +398,36 @@ export class Datanodes extends
React.Component<Record<string, object>, IDatanode
return selectedColumns;
};
- _loadData = () => {
- this.setState(prevState => ({
- loading: true,
- selectedColumns: this._getSelectedColumns(prevState.selectedColumns)
- }));
-
- const { request, controller } = AxiosGetHelper('/api/v1/datanodes',
cancelSignal);
- cancelSignal = controller;
- request.then(response => {
- const datanodesResponse: IDatanodesResponse = response.data;
+ _loadData = async () => {
+ // Need to call decommission API on each interval to get updated status
before datanode API to compare UUID's
+ // update Operation State Column in table Manually before rendering
+ try {
+ let decomissionResponse = await this._loadDecommisionAPI();
+ decommissionUuids = decomissionResponse && decomissionResponse.data &&
+ decomissionResponse.data.DatanodesDecommissionInfo &&
+ decomissionResponse.data.DatanodesDecommissionInfo.map((item: {
datanodeDetails: { uuid: any; }; }) => item.datanodeDetails.uuid);
Review Comment:
Also please define a type for DatanodeDecomissionInfo as:
```
type DatanodeDetails = {
uuid: string;
}
type DatanodeDecomissionInfo = {
datanodeDetails: DatanodeDetails
}
```
```suggestion
decomissionResponse.data.DatanodesDecommissionInfo.map((item:
DatanodeDecomissionInfo) => item.datanodeDetails.uuid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
