adoroszlai commented on code in PR #7043:
URL: https://github.com/apache/ozone/pull/7043#discussion_r1706820119
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -176,8 +176,8 @@ private synchronized void connectToDatanode(DatanodeDetails
dn)
// Add credential context to the client call
if (LOG.isDebugEnabled()) {
- LOG.debug("Nodes in pipeline : {}", pipeline.getNodes());
- LOG.debug("Connecting to server : {}", dn.getIpAddress());
+ LOG.debug("Nodes in pipeline : {}, connecting to server : {}",
+ pipeline.getNodes(), dn.getIpAddress());
Review Comment:
Let's swap the parts of the message to make it easier to see the selected
node. List of nodes in pipeline can be longer. Also, rely on
`DatanodeDetails.toString()` to get more information (hostname and UUID in
addition to IP address).
```suggestion
LOG.debug("Connecting to server: {}; nodes in pipeline: {}",
dn, pipeline.getNodes());
```
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -176,8 +176,8 @@ private synchronized void connectToDatanode(DatanodeDetails
dn)
// Add credential context to the client call
Review Comment:
Please remove this outdated comment (no credential-related code here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
