errose28 commented on PR #6945: URL: https://github.com/apache/ozone/pull/6945#issuecomment-2273721975
@aswinshakil Why was the checksum manager added as a parameter to the key value handler after the branch update? This is not in the [branch](https://github.com/apache/ozone/blob/HDDS-10239-container-reconciliation/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java#L152), and was not in the PR at commit 7e57538 prior to the merge commit. The implementation I have in HDDS-11254 does not pass this through the constructor either so it is a sweeping change we would just have to undo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
