ChenSammi commented on code in PR #7010:
URL: https://github.com/apache/ozone/pull/7010#discussion_r1708727419
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -1312,6 +1325,42 @@ public double getInflightReplicationLimitFactor() {
return inflightReplicationLimitFactor;
}
+ @Config(key = "inflight.off-peak.hour",
+ type = ConfigType.STRING,
+ defaultValue = "-1",
+ reconfigurable = true,
+ tags = { SCM },
+ description = "Set the time information of the replication
off-peak period. " +
+ "The default value -1 means turning off this parameter.
The normal" +
+ " start time is 0 to 23 hours, separated by commas. For
example, '0,1,8,9,12'"
+ )
+ private String inflightOffPeakHour = "-1";
+
+ public String getInflightOffPeakHour() {
+ return inflightOffPeakHour;
+ }
+
+ public void setInflightOffPeakHour(String hour) {
+ this.inflightOffPeakHour = hour;
Review Comment:
Can you have a check here to make sure the string format is as expected, and
no number more than 23?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
