smitajoshi12 commented on code in PR #7037:
URL: https://github.com/apache/ozone/pull/7037#discussion_r1713252525
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/missingContainers/missingContainers.tsx:
##########
@@ -398,22 +398,22 @@ export class MissingContainers extends
React.Component<Record<string, object>, I
<Tabs defaultActiveKey='1'>
<Tabs.TabPane
key='1'
- tab={`Missing${(missingDataSource && missingDataSource.length >
0) ? ` (${missingDataSource.length})` : ''}`}>
+ tab={`Missing${(missingDataSource?.length > 0) ? `
(${missingDataSource.length})` : ''}`}>
{generateTable(missingDataSource)}
</Tabs.TabPane>
<Tabs.TabPane
key='2'
- tab={`Under-Replicated${(underReplicatedDataSource &&
underReplicatedDataSource.length > 0) ? `
(${underReplicatedDataSource.length})` : ''}`}>
+ tab={`Under-Replicated${(underReplicatedDataSource?.length > 0)
? ` (${underReplicatedDataSource.length})` : ''}`}>
{generateTable(underReplicatedDataSource)}
</Tabs.TabPane>
<Tabs.TabPane
key='3'
- tab={`Over-Replicated${(overReplicatedDataSource &&
overReplicatedDataSource.length > 0) ? ` (${overReplicatedDataSource.length})`
: ''}`}>
+ tab={`Over-Replicated${(overReplicatedDataSource?.length > 0) ?
` (${overReplicatedDataSource.length})` : ''}`}>
{generateTable(overReplicatedDataSource)}
</Tabs.TabPane>
<Tabs.TabPane
key='4'
- tab={`Mis-Replicated${(misReplicatedDataSource &&
misReplicatedDataSource.length > 0) ? ` (${misReplicatedDataSource.length})` :
''}`}>
+ tab={`Mis-Replicated${(misReplicatedDataSource?.length > 0) ? `
(${misReplicatedDataSource.length})` : ''}`}>
Review Comment:
Done changes in latest commit 878b46ef6f3090e43a104f606bdf49ad890f0e4f
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx:
##########
@@ -116,8 +116,8 @@ const COLUMNS = [
render: (datanodes: string[]) => <div> {datanodes &&
datanodes.map(datanode =>
<div key={datanode.hostName}>
<div className='uuidtooltip'>
- <Tooltip placement='top' title={`UUID: ${datanode &&
datanode.uuid}`} getPopupContainer={(triggerNode) => triggerNode}>
- {datanode && datanode.hostName}
+ <Tooltip placement='top' title={`UUID: ${datanode?.uuid}`}
getPopupContainer={(triggerNode) => triggerNode}>
+ {datanode?.hostName}
Review Comment:
Done changes in latest commit 878b46ef6f3090e43a104f606bdf49ad890f0e4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
