tanvipenumudy commented on code in PR #7060:
URL: https://github.com/apache/ozone/pull/7060#discussion_r1714948574
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1762,20 +1762,15 @@ public List<OzoneKey> listKeys(String volumeName,
String bucketName,
@Override
public List<RepeatedOmKeyInfo> listTrash(String volumeName, String
bucketName,
String startKeyName, String keyPrefix, int maxKeys) throws IOException {
-
- Preconditions.checkNotNull(volumeName);
- Preconditions.checkNotNull(bucketName);
-
- return ozoneManagerClient.listTrash(volumeName, bucketName, startKeyName,
- keyPrefix, maxKeys);
+ // listTrash is deprecated
+ throw new UnsupportedOperationException();
}
@Override
public boolean recoverTrash(String volumeName, String bucketName,
String keyName, String destinationBucket) throws IOException {
-
- return ozoneManagerClient.recoverTrash(volumeName, bucketName, keyName,
- destinationBucket);
+ //recoverTrash is deprecated
+ throw new UnsupportedOperationException();
Review Comment:
Similar to the previous comment, do we just mark the method with a
`@Deprecated` annotation instead?
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1762,20 +1762,15 @@ public List<OzoneKey> listKeys(String volumeName,
String bucketName,
@Override
public List<RepeatedOmKeyInfo> listTrash(String volumeName, String
bucketName,
String startKeyName, String keyPrefix, int maxKeys) throws IOException {
-
- Preconditions.checkNotNull(volumeName);
- Preconditions.checkNotNull(bucketName);
-
- return ozoneManagerClient.listTrash(volumeName, bucketName, startKeyName,
- keyPrefix, maxKeys);
+ // listTrash is deprecated
+ throw new UnsupportedOperationException();
Review Comment:
Should we mark the methods with a `@Deprecated` annotation instead of
removing their implementation and throwing an `UnsupportedOperationException`,
for the sake of consistency
Perhaps similar to `setEncryptionKey()` and `renameKeys()` APIs (now
deprecated)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
