jojochuang commented on code in PR #7074:
URL: https://github.com/apache/ozone/pull/7074#discussion_r1718736753
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -343,7 +343,7 @@ public List<BlockData> listBlock(Container container, long
startLocalID, int
.getSequentialRangeKVs(startKey, count,
cData.containerPrefix(), cData.getUnprefixedKeyFilter());
for (Table.KeyValue<String, BlockData> entry : range) {
- result.add(entry.getValue());
+ result.add(db.getStore().getBlockByID(null, entry.getKey()));
Review Comment:
If incremental chunk list feature is enabled, the last chunk of a block may
exist in the lastChunkInfoTable. So getBlockByID() is used here to get the
complete block data.
There could be opportunities to optimize later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
