jojochuang commented on code in PR #7072:
URL: https://github.com/apache/ozone/pull/7072#discussion_r1720248022
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -477,31 +477,32 @@ private void adjustBuffersOnException() {
/**
* Watch for a specific commit index.
Review Comment:
please update this javadoc to reflect the new behavior.
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -477,31 +477,32 @@ private void adjustBuffersOnException() {
/**
* Watch for a specific commit index.
*/
- XceiverClientReply sendWatchForCommit(long commitIndex)
- throws IOException {
- return null;
+ CompletableFuture<XceiverClientReply> sendWatchForCommit(long commitIndex) {
+ return CompletableFuture.completedFuture(null);
}
- private void watchForCommit(long commitIndex) throws IOException {
- checkOpen();
- try {
- LOG.debug("Entering watchForCommit commitIndex = {}", commitIndex);
- final XceiverClientReply reply = sendWatchForCommit(commitIndex);
- if (reply != null) {
- List<DatanodeDetails> dnList = reply.getDatanodes();
- if (!dnList.isEmpty()) {
- Pipeline pipe = xceiverClient.getPipeline();
-
- LOG.warn("Failed to commit BlockId {} on {}. Failed nodes: {}",
- blockID, pipe, dnList);
- failedServers.addAll(dnList);
- }
- }
- } catch (IOException ioe) {
- setIoException(ioe);
- throw getIoException();
+ private CompletableFuture<Void> watchForCommit(long commitIndex) {
+ LOG.debug("Entering watchForCommit commitIndex = {}", commitIndex);
+ return sendWatchForCommit(commitIndex)
+ .thenAccept(this::checkReply)
+ .exceptionally(e -> {
+ throw new FlushRuntimeException(setIoException(e));
+ })
+ .whenComplete((r, e) -> LOG.debug("Leaving watchForCommit commitIndex
= {}", commitIndex));
+ }
+
+ void checkReply(XceiverClientReply reply) {
Review Comment:
can this method be made private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
