ChenSammi opened a new pull request, #7094: URL: https://github.com/apache/ozone/pull/7094
## What changes were proposed in this pull request? Currently, for every client side buffer flush size(32MB default), there will be a putBlock call to DN to persist the block metadata. For a 128MB block, there will be 4 putBlock calls during the data write, and one extra putBlock at the end when this block is closed due to full. This last putBlock will add the flag "eof" in the request to indicate that this block is completed. This task aims to remove this last putBlock call in case this block is a full block when block is called. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-11340 ## How was this patch tested? Existing test cases, plus manual audit log verification. Before the patch, here are the audit logs, the block size 32MB. ``` 2024-08-19 21:29:26,396 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=0, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=19, opLatencyMs=32} | 2024-08-19 21:29:26,397 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=4194304, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=1} | 2024-08-19 21:29:26,418 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=0, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,422 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=4194304, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,436 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=8388608, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=2} | 2024-08-19 21:29:26,439 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=8388608, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,465 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=12582912, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=1} | 2024-08-19 21:29:26,467 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=12582912, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,477 | INFO | DNAudit | user=null | ip=null | op=PUT_BLOCK {blockData=[blockId=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: null, size=16777216]} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=7} | 2024-08-19 21:29:26,483 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=16777216, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=2} | 2024-08-19 21:29:26,484 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=16777216, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,500 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=20971520, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=1} | 2024-08-19 21:29:26,504 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=20971520, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,524 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=25165824, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=1} | 2024-08-19 21:29:26,526 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=25165824, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,539 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=29360128, size=4194304, stage=WRITE_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=1} | 2024-08-19 21:29:26,545 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: 0, offset=29360128, size=4194304, stage=COMMIT_DATA} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=0} | 2024-08-19 21:29:26,551 | INFO | DNAudit | user=null | ip=null | op=PUT_BLOCK {blockData=[blockId=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: null, size=33554432]} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=2} | 2024-08-19 21:29:26,576 | INFO | DNAudit | user=null | ip=null | op=PUT_BLOCK {blockData=[blockId=conID: 2001 locID: 113750153625602004 bcsId: 0 replicaIndex: null, size=33554432]} | ret=null | perf={preOpLatencyMs=0, opLatencyMs=4} | ``` after the patch ``` 2024-08-19 22:08:28,508 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240420885044, opLatencyMs=28845125} | 2024-08-19 22:08:28,512 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240452817194, opLatencyMs=1545333} | 2024-08-19 22:08:28,514 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240454482485, opLatencyMs=2044583} | 2024-08-19 22:08:28,522 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240462158935, opLatencyMs=1801875} | 2024-08-19 22:08:28,522 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240464377266, opLatencyMs=52292} | 2024-08-19 22:08:28,525 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240467488055, opLatencyMs=61125} | 2024-08-19 22:08:28,526 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240468259054, opLatencyMs=86708} | 2024-08-19 22:08:28,527 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240468926345, opLatencyMs=34291} | 2024-08-19 22:08:28,537 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240476854462, opLatencyMs=2298291} | 2024-08-19 22:08:28,538 | INFO | DNAudit | user=null | ip=null | op=PUT_BLOCK {blockData=[blockId=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: null, size=16777216]} | ret=null | perf={preOpLatencyMs=-561240470193760, opLatencyMs=9853542} | 2024-08-19 22:08:28,538 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240480741874, opLatencyMs=54167} | 2024-08-19 22:08:28,551 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240491555406, opLatencyMs=1393083} | 2024-08-19 22:08:28,552 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240494505445, opLatencyMs=62625} | 2024-08-19 22:08:28,566 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240506190266, opLatencyMs=1912792} | 2024-08-19 22:08:28,568 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240510633054, opLatencyMs=72541} | 2024-08-19 22:08:28,578 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240518328587, opLatencyMs=1434459} | 2024-08-19 22:08:28,579 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240521221084, opLatencyMs=61167} | 2024-08-19 22:08:28,581 | INFO | DNAudit | user=null | ip=null | op=PUT_BLOCK {blockData=[blockId=conID: 2004 locID: 113750153625602007 bcsId: 0 replicaIndex: null, size=33554432]} | ret=null | perf={preOpLatencyMs=-561240521807333, opLatencyMs=1738125} | 2024-08-19 22:08:28,613 | INFO | DNAudit | user=null | ip=null | op=WRITE_CHUNK {blockData=conID: 2005 locID: 113750153625602008 bcsId: 0 replicaIndex: 0, blockDataSize=4194304} | ret=null | perf={preOpLatencyMs=-561240549952095, opLatencyMs=5258083} | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
