ivandika3 commented on code in PR #7091:
URL: https://github.com/apache/ozone/pull/7091#discussion_r1722645709
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java:
##########
@@ -126,9 +116,6 @@ public Void call() throws Exception {
for (FSDataOutputStream outputStream : outputStreams) {
outputStream.close();
}
- for (FileSystem fs : fileSystems) {
Review Comment:
I think this is added due to my suggestion
https://github.com/apache/ozone/pull/6925/commits/1d273dffe468b90956bafb1b0a2dffd93be867cf,
but I think a since FileSystem cache is not disabled, it will still use the
same FileSystem instance anyway.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HsyncGenerator.java:
##########
@@ -126,9 +116,6 @@ public Void call() throws Exception {
for (FSDataOutputStream outputStream : outputStreams) {
outputStream.close();
}
- for (FileSystem fs : fileSystems) {
Review Comment:
I think this is added due to my suggestion
https://github.com/apache/ozone/pull/6925/commits/1d273dffe468b90956bafb1b0a2dffd93be867cf,
but I think since FileSystem cache is not disabled, it will still use the same
FileSystem instance anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
