slfan1989 commented on code in PR #7090:
URL: https://github.com/apache/ozone/pull/7090#discussion_r1724460561


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java:
##########
@@ -112,7 +119,7 @@ public class StateContext {
   private final Map<InetSocketAddress, List<Message>>
       incrementalReportsQueue;
   private final Map<InetSocketAddress, Queue<ContainerAction>> 
containerActions;

Review Comment:
   Thank you for your contributions! We have updated the code, and its 
readability has improved, which is a great thing. The code for container 
reporting and pipeline reporting is similar, but since we have not encountered 
issues with the container code, does this imply that there are no problems with 
this segment of the code, considering that the number of containers is much 
larger than the number of pipelines?
   
   Upon careful consideration of the differences between container and pipeline 
reporting, I personally suspect that the issue might be related to the Ratis 
state management in the pipeline. We have identified some details and will be 
submitting an issue. I hope to continue discussing this with you. @szetszwo
   



##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java:
##########
@@ -112,7 +119,7 @@ public class StateContext {
   private final Map<InetSocketAddress, List<Message>>
       incrementalReportsQueue;
   private final Map<InetSocketAddress, Queue<ContainerAction>> 
containerActions;

Review Comment:
   Upon careful consideration of the differences between container and pipeline 
reporting, I personally suspect that the issue might be related to the Ratis 
state management in the pipeline. We have identified some details and will be 
submitting an issue. I hope to continue discussing this with you. @szetszwo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to