jojochuang commented on code in PR #7081:
URL: https://github.com/apache/ozone/pull/7081#discussion_r1725545058
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2591,11 +2603,22 @@ public KeyProvider call() throws Exception {
}
}
+ @Override
+ public OzoneFsServerDefaults getServerDefaults() throws IOException {
Review Comment:
would be great to have a test to verify this where it makes sure a second
call within the expiration time to this API does not invoke
ozoneManagerClient.getServerDefaults()
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -1107,6 +1108,11 @@ public short getDefaultReplication() {
return adapter.getDefaultReplication();
}
+ @Override
+ public OzoneFsServerDefaults getServerDefaults() throws IOException {
Review Comment:
need tests at file system level for ofs and o3fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
