devmadhuu commented on code in PR #7088: URL: https://github.com/apache/ozone/pull/7088#discussion_r1732441598
########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/navBar/navBar.tsx: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import React, { useState, useEffect } from 'react'; +import axios, { AxiosResponse } from 'axios'; +import { Layout, Menu, Spin } from 'antd'; +import { + BarChartOutlined, + ClusterOutlined, + ContainerOutlined, + DashboardOutlined, + DatabaseOutlined, + DeploymentUnitOutlined, + FolderOpenOutlined, + InboxOutlined, + LayoutOutlined, + PieChartOutlined +} from '@ant-design/icons'; +import { useLocation, Link } from 'react-router-dom'; + + +import logo from '@/logo.png'; +import { showDataFetchError } from '@/utils/common'; +import { AxiosGetHelper, cancelRequests } from '@/utils/axiosRequestHelper'; + +import './navBar.less'; + + +// ------------- Types -------------- // +type NavBarProps = { + collapsed: boolean; + onCollapse: (arg0: boolean) => void; +} + +const NavBar: React.FC<NavBarProps> = ({ + collapsed = false, + onCollapse = () => { } +}) => { + const [isHeatmapEnabled, setIsHeatmapEnabled] = useState<boolean>(false); + let cancelDisabledFeatureSignal: AbortController; + const location = useLocation(); + + const fetchDisabledFeatures = async () => { + const disabledfeaturesEndpoint = `/api/v1/features/disabledFeatures`; + const { request, controller } = AxiosGetHelper( + disabledfeaturesEndpoint, + cancelDisabledFeatureSignal + ) + cancelDisabledFeatureSignal = controller; + try { + const response: AxiosResponse<string[]> = await request; + const heatmapDisabled = response?.data?.includes('HEATMAP') + setIsHeatmapEnabled(!heatmapDisabled) + } catch (error: unknown) { + showDataFetchError((error as Error).toString()) + } + } + + + useEffect(() => { + fetchDisabledFeatures(); + // Component will unmount + return (() => { + cancelRequests([cancelDisabledFeatureSignal]) + }) + }, []) Review Comment: ```suggestion }, [fetchDisabledFeatures]) ``` ########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/navBar/navBar.tsx: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import React, { useState, useEffect } from 'react'; +import axios, { AxiosResponse } from 'axios'; +import { Layout, Menu, Spin } from 'antd'; +import { + BarChartOutlined, + ClusterOutlined, + ContainerOutlined, + DashboardOutlined, + DatabaseOutlined, + DeploymentUnitOutlined, + FolderOpenOutlined, + InboxOutlined, + LayoutOutlined, + PieChartOutlined +} from '@ant-design/icons'; +import { useLocation, Link } from 'react-router-dom'; + + +import logo from '@/logo.png'; +import { showDataFetchError } from '@/utils/common'; +import { AxiosGetHelper, cancelRequests } from '@/utils/axiosRequestHelper'; + +import './navBar.less'; + + +// ------------- Types -------------- // +type NavBarProps = { + collapsed: boolean; + onCollapse: (arg0: boolean) => void; +} + +const NavBar: React.FC<NavBarProps> = ({ + collapsed = false, + onCollapse = () => { } +}) => { + const [isHeatmapEnabled, setIsHeatmapEnabled] = useState<boolean>(false); + let cancelDisabledFeatureSignal: AbortController; + const location = useLocation(); + + const fetchDisabledFeatures = async () => { + const disabledfeaturesEndpoint = `/api/v1/features/disabledFeatures`; + const { request, controller } = AxiosGetHelper( + disabledfeaturesEndpoint, + cancelDisabledFeatureSignal + ) + cancelDisabledFeatureSignal = controller; + try { + const response: AxiosResponse<string[]> = await request; + const heatmapDisabled = response?.data?.includes('HEATMAP') + setIsHeatmapEnabled(!heatmapDisabled) + } catch (error: unknown) { + showDataFetchError((error as Error).toString()) + } + } + + + useEffect(() => { + fetchDisabledFeatures(); + // Component will unmount + return (() => { + cancelRequests([cancelDisabledFeatureSignal]) + }) + }, []) + + const menuItems = [( + <Menu.Item key='/Overview' + icon={<DashboardOutlined />}> + <span>Overview</span> + <Link to='/Overview' /> + </Menu.Item> + ), ( + <Menu.Item key='/Volumes' + icon={<InboxOutlined />}> + <span>Volumes</span> + <Link to='/Volumes' /> + </Menu.Item> + ), ( + <Menu.Item key='/Buckets' + icon={<FolderOpenOutlined />}> + <span>Buckets</span> + <Link to='/Buckets' /> + </Menu.Item> + ), ( + <Menu.Item key='/Datanodes' + icon={<ClusterOutlined />}> + <span>Datanodes</span> + <Link to='/Datanodes' /> + </Menu.Item> + ), ( + <Menu.Item key='/Pipelines' + icon={<DeploymentUnitOutlined />}> + <span>Pipelines</span> + <Link to='/Pipelines' /> + </Menu.Item> + ), ( + <Menu.Item key='/Containers' + icon={<ContainerOutlined />}> + <span>Containers</span> + <Link to='/Containers' /> + </Menu.Item> + ), ( + <Menu.SubMenu key='InsightsMenu' + title="Insights" + icon={<BarChartOutlined />}> + <Menu.Item key='/Insights' + icon={<BarChartOutlined />}> + <span>Insights</span> + <Link to='/Insights' /> + </Menu.Item> + <Menu.Item key='/Om' + icon={<DatabaseOutlined />}> + <span>OM DB Insights</span> + <Link to='/Om' /> + </Menu.Item> + </Menu.SubMenu> + ), ( + <Menu.Item key='/DiskUsage' + icon={<PieChartOutlined />}> + <span>Disk Usage</span> + <Link to='/DiskUsage' /> + </Menu.Item> + ), ( + isHeatmapEnabled + ? <> Review Comment: ```suggestion {isHeatmapEnabled && ( <Menu.Item key='/Heatmap' icon={<LayoutOutlined />}> <span>Heatmap</span> <Link to={{ pathname: '/Heatmap', state: { isHeatmapEnabled: true } }} /> </Menu.Item> )} ``` ########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/navBar/navBar.tsx: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import React, { useState, useEffect } from 'react'; +import axios, { AxiosResponse } from 'axios'; +import { Layout, Menu, Spin } from 'antd'; +import { + BarChartOutlined, + ClusterOutlined, + ContainerOutlined, + DashboardOutlined, + DatabaseOutlined, + DeploymentUnitOutlined, + FolderOpenOutlined, + InboxOutlined, + LayoutOutlined, + PieChartOutlined +} from '@ant-design/icons'; +import { useLocation, Link } from 'react-router-dom'; + + +import logo from '@/logo.png'; +import { showDataFetchError } from '@/utils/common'; +import { AxiosGetHelper, cancelRequests } from '@/utils/axiosRequestHelper'; + +import './navBar.less'; + + +// ------------- Types -------------- // +type NavBarProps = { + collapsed: boolean; + onCollapse: (arg0: boolean) => void; +} + +const NavBar: React.FC<NavBarProps> = ({ + collapsed = false, + onCollapse = () => { } +}) => { + const [isHeatmapEnabled, setIsHeatmapEnabled] = useState<boolean>(false); + let cancelDisabledFeatureSignal: AbortController; + const location = useLocation(); + + const fetchDisabledFeatures = async () => { + const disabledfeaturesEndpoint = `/api/v1/features/disabledFeatures`; + const { request, controller } = AxiosGetHelper( + disabledfeaturesEndpoint, + cancelDisabledFeatureSignal + ) + cancelDisabledFeatureSignal = controller; Review Comment: Any issue ? if the component re-renders and the effect is re-triggered ? Can we avoid Avoid reassigning the controller and ensure the previous controller is properly cleaned up. ########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/navBar/navBar.tsx: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import React, { useState, useEffect } from 'react'; +import axios, { AxiosResponse } from 'axios'; +import { Layout, Menu, Spin } from 'antd'; +import { + BarChartOutlined, + ClusterOutlined, + ContainerOutlined, + DashboardOutlined, + DatabaseOutlined, + DeploymentUnitOutlined, + FolderOpenOutlined, + InboxOutlined, + LayoutOutlined, + PieChartOutlined +} from '@ant-design/icons'; +import { useLocation, Link } from 'react-router-dom'; + + +import logo from '@/logo.png'; +import { showDataFetchError } from '@/utils/common'; +import { AxiosGetHelper, cancelRequests } from '@/utils/axiosRequestHelper'; + +import './navBar.less'; + + +// ------------- Types -------------- // +type NavBarProps = { + collapsed: boolean; + onCollapse: (arg0: boolean) => void; +} + +const NavBar: React.FC<NavBarProps> = ({ + collapsed = false, + onCollapse = () => { } +}) => { + const [isHeatmapEnabled, setIsHeatmapEnabled] = useState<boolean>(false); + let cancelDisabledFeatureSignal: AbortController; Review Comment: The cancelDisabledFeatureSignal is declared with let but is never reassigned, potentially leading to unexpected behavior if the component re-renders. ```suggestion const [cancelDisabledFeatureSignal, setCancelDisabledFeatureSignal] = useState<AbortController>(new AbortController()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
