fapifta commented on PR #7062: URL: https://github.com/apache/ozone/pull/7062#issuecomment-2313880236
It seems that the change from direct executor to ThreadPoolExecutor causes some trouble in the tests. I would guess adding Thread.sleep would solve the problem, but may I suggest to use some wait mechanism instead of just sleeping for some time? Maybe we can use a lock that is being locked before the handler.handle call, and being unlocked in the afterExecute method in the ThreadPoolExecutor (we need to sub-class it to specify afterExecute). This would better avoid flakiness then simply call thread sleep, and will also reduce the test runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
