Wei-Chiu Chuang created HDDS-11402:
--------------------------------------
Summary: FilePerBlockStrategy write path doesn't have a file lock
Key: HDDS-11402
URL: https://issues.apache.org/jira/browse/HDDS-11402
Project: Apache Ozone
Issue Type: Bug
Reporter: Wei-Chiu Chuang
ChunkUtils implements a File read/write lock when reading chunk files. It's
added by HDDS-11281 to replace the original design that implemented an
exclusive lock for chunk files.
I just realized it doesn't work for blocks files (FilePerBlockStrategy), which
is the default container layout. So it's a pure overhead for most users. What
does it do for block files? Can we simply disable it for block files?
In fact, even the original, exclusive lock design doesn't work for
FilePerBlockStrategy.
https://github.com/apache/ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/ChunkUtils.java
The file lock on the write path is only instantiated by writeDataToFile(),
called by writeData(File, ChunkBuffer, long, long, HddsVolume, boolean), called
by FilePerChunkStrategy.
cc: [~adoroszlai] [~Nicholas Niu] [~ritesh]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
