errose28 commented on code in PR #6916:
URL: https://github.com/apache/ozone/pull/6916#discussion_r1742281020
##########
.github/workflows/ci.yml:
##########
@@ -166,6 +166,99 @@ jobs:
path: |
~/.m2/repository/org/apache/ozone
retention-days: 1
+ build-config-doc:
+ needs:
+ - build
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v4
+ - name: Set up Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.x'
+ - name: Download the source artifact
+ uses: actions/download-artifact@v4
+ with:
+ name: ozone-bin
+ path: ozone-bin
+ - name: Extract the source tarball
+ run: |
+ mkdir -p ozone-bin/extracted
+ tar -xzf ozone-bin/ozone-*-SNAPSHOT.tar.gz -C ozone-bin/extracted
+ - name: Calculate hash of the existing Configurations.md
Review Comment:
Since the config doc needs to get generated anyways I think we can simplify
all of these check steps down to just two:
1. Generate md file.
2. Using GH actions conditionals and
[hash](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#hashfiles),
set a flag/variable in the job if the hashes don't match.
- This way we do not need the intermediate hash txt files.
Unfortunately it looks like we will still need the "hashes differ" check in
each of the following steps due to GH actions limitations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
