Montura commented on code in PR #7134:
URL: https://github.com/apache/ozone/pull/7134#discussion_r1742354641
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/MockedSCM.java:
##########
@@ -86,7 +86,7 @@ public MockedSCM(@Nonnull TestableCluster testableCluster) {
}
}
- private void init(@Nonnull ContainerBalancerConfiguration balancerConfig,
@Nonnull OzoneConfiguration ozoneCfg) {
+ void init(@Nonnull ContainerBalancerConfiguration balancerConfig, @Nonnull
OzoneConfiguration ozoneCfg) {
Review Comment:
I'd prefer to save `init` as private method and add two public methods for
`ContainerBalancerTask` creating (without running) to allow run it in another
thread:
```
public @Nonnull ContainerBalancerTask createBalancerTask(
@Nonnull ContainerBalancerConfiguration config
) {
init(config, new OzoneConfiguration());
return createBalancerTask(new ContainerBalancer(scm), config);
}
public @Nonnull ContainerBalancerTask createBalancerTask(
@Nonnull ContainerBalancer containerBalancer,
@Nonnull ContainerBalancerConfiguration config
) {
return new ContainerBalancerTask(scm, 0, containerBalancer,
containerBalancer.getMetrics(), config, false);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
