sadanand48 commented on code in PR #7147:
URL: https://github.com/apache/ozone/pull/7147#discussion_r1746610374
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1329,12 +1327,12 @@ public ListKeysResult listKeys(String volumeName,
String bucketName,
while (currentCount < maxKeys + 1 && keyIter.hasNext()) {
kv = keyIter.next();
if (kv != null && kv.getKey().startsWith(seekPrefix)) {
-
- // Entry should not be marked for delete, consider only those
- // entries.
- CacheValue<OmKeyInfo> cacheValue =
- keyTable.getCacheValue(new CacheKey<>(kv.getKey()));
- if (cacheValue == null || cacheValue.getCacheValue() != null) {
+ if (cacheKeyMap.containsKey(kv.getKey())) {
Review Comment:
I don't get why changes are needed here in listKeys ? Why does changing
internal logic of PartialTableCache affect this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
