swamirishi commented on code in PR #7097:
URL: https://github.com/apache/ozone/pull/7097#discussion_r1747865059


##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java:
##########
@@ -116,6 +116,22 @@ public interface OMMetadataManager extends 
DBStoreHAManager {
    */
   String getBucketKey(String volume, String bucket);
 
+  /**
+   * Given a volume and bucket, return the corresponding DB key prefix.
+   *
+   * @param volume - User name
+   * @param bucket - Bucket name
+   */
+  String getBucketKeyPrefix(String volume, String bucket);

Review Comment:
   Snapshot code shouldn't be hitting metadata manager layer. All reads should 
be made to KeyManager & keyManager should inturn hit metadata layer. From what 
I understand, this was the intent of creation of these interface initially. We 
ended up mixing all of this logic everywhere by directly accessing tables from 
all the places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to