sumitagrawl commented on PR #7177: URL: https://github.com/apache/ozone/pull/7177#issuecomment-2339762630
> What is the use case for this command? Is just a hypothetical "in case we need it in the future" type of thing or have we seen legitimate bugs where this would have helped? IMO this command is somewhat complicated and dangerous, even for a `repair` subcommand, and should not be added without a very strong reason. @errose28 There are multiple issues happened earlier, - HDDS-9876: replay of transaction, as recovery, need update transactionInfoTable - HDDS-7449: bucket encryption key overwrite - key filename corruption in DB due to concurrent cache update and persist (do not remember exact issue ID) - Many more issues where repair may be avoided using script So for first 2, we have provided specific repair method via ozone OR new feature implemented to repair respectively. This capability provides flexibility to delivery script as recovery based on any specific issue And Avoid repair command or new feature for any specific issue in particular version. Also any recovery can be provided without releasing as software itself which will be quick and avoid frequent releases. Example, using shell script, it can query all bucket missing encryption and update with encryption key using the script as solution. Also for transactionInfo update, instead of having separate repair command, script which can use this option to fix. So idea is to avoid version specific bug repair as feature, and provide a script / steps to recover with generic options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
