devmadhuu commented on code in PR #7149:
URL: https://github.com/apache/ozone/pull/7149#discussion_r1753346635
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -185,17 +185,16 @@ public void testMissingContainerDownNode() throws
Exception {
}
/**
- * This test verifies the count of MISSING and EMPTY_MISSING containers.
+ * This test verifies the count of MISSING containers.
* Following steps being followed in a single DN cluster.
* --- Allocate a container in SCM.
* --- Client writes the chunk and put block to only DN successfully.
* --- Shuts down the only DN.
* --- Since container to key mapping doesn't have any key mapped to
- * container, missing container will be marked EMPTY_MISSING.
+ * container, missing container will be marked MISSING.
* --- Add a key mapping entry to key container mapping table for the
* container added.
- * --- Now container will no longer be marked as EMPTY_MISSING and just
- * as MISSING.
+ * --- Now container will no longer be marked as MISSING.
Review Comment:
Pls correct this comment.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -185,17 +185,16 @@ public void testMissingContainerDownNode() throws
Exception {
}
/**
- * This test verifies the count of MISSING and EMPTY_MISSING containers.
+ * This test verifies the count of MISSING containers.
* Following steps being followed in a single DN cluster.
* --- Allocate a container in SCM.
* --- Client writes the chunk and put block to only DN successfully.
* --- Shuts down the only DN.
* --- Since container to key mapping doesn't have any key mapped to
- * container, missing container will be marked EMPTY_MISSING.
+ * container, missing container will be marked MISSING.
Review Comment:
Pls correct this comment.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -236,14 +235,14 @@ public void testEmptyMissingContainerDownNode() throws
Exception {
// Bring down the Datanode that had the container replica.
cluster.shutdownHddsDatanode(pipeline.getFirstNode());
+ // Verify that the container is marked as MISSING
LambdaTestUtils.await(25000, 1000, () -> {
- List<UnhealthyContainers> allEmptyMissingContainers =
+ List<UnhealthyContainers> allMissingContainers =
reconContainerManager.getContainerSchemaManager()
.getUnhealthyContainers(
- ContainerSchemaDefinition.UnHealthyContainerStates.
- EMPTY_MISSING,
+ ContainerSchemaDefinition.UnHealthyContainerStates.MISSING,
0, 1000);
- return (allEmptyMissingContainers.size() == 1);
+ return (allMissingContainers.size() == 1);
Review Comment:
Something wrong here, container should not be marked as `MISSING` here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
