swamirishi commented on PR #7179: URL: https://github.com/apache/ozone/pull/7179#issuecomment-2343917957
> > > The patch overall looks good to me. I have a question, Shouldn't we also update the `lastTransactionInfo` on `OMSnapshotSetPropertyRequest`, `OMSnapshotDeleteRequest` and `OMSnapshotRenameRequest` as these requests are also updating the Snapshot's metadata. > > > > > > We don't technically need it, since all of these changes are going to go to just the SnapshotInfo table and not the physical rocksdb. > > Not sure I understand this. Whenever we update only snapshot meta, we are just updating the snapshotInfo table in AOS OM rocksdb, and we are not updating the snapshotted rocksdb content. For GC we are only concerned about the snapshotted rocksdb's table content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
