smengcl commented on code in PR #7184:
URL: https://github.com/apache/ozone/pull/7184#discussion_r1755233811
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java:
##########
@@ -317,9 +317,6 @@ public static boolean canEnableHsync(ConfigurationSource
conf, boolean isClient)
if (confHBaseEnhancementsAllowed) {
return confHsyncEnabled;
} else {
- LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To
enable it, set {} = true as well.",
- OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
- confKey);
return false;
Review Comment:
ah I see the mistake I made in the previous jira. Let's do this instead.
This was there for a reason as I mentioned above. But I missed the extra check.
```suggestion
if (confHsyncEnabled) {
LOG.warn("Ignoring {} = {} because HBase enhancements are
disallowed. To enable it, set {} = true as well.",
OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
confKey);
}
return false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
