slfan1989 commented on code in PR #7016:
URL: https://github.com/apache/ozone/pull/7016#discussion_r1756172167
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java:
##########
@@ -760,8 +767,26 @@ public ScmInfo getScmInfo() throws IOException {
.setScmId(resp.getScmId())
.setRatisPeerRoles(resp.getPeerRolesList());
- return builder.build();
+ // By default, we assume that SCM Ratis is not enabled.
Review Comment:
We have considered whether the `ScmRatisEnabled` field exists in the proto.
If the field is not present, we determine whether Ratis is enabled based on
whether `peerRolesList` includes `leader` or `follower`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
