Tejaskriya commented on code in PR #7167:
URL: https://github.com/apache/ozone/pull/7167#discussion_r1751319646


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java:
##########
@@ -128,6 +129,14 @@ public class DBScanner implements Callable<Void>, 
SubcommandWithParent {
           "eg.) \"name,acls.type\" for showing name and type under acls.")
   private String fieldsFilter;
 
+  @CommandLine.Option(names = {"--filter"},
+      description = "Comma-separated list of \"<field>:<operator>:<value>\" 
where " +
+          "<field> is any valid field of the record, " +
+          "<operator> is (EQUALS,MAX or MIN) and " +
+          "<value> is the value of the field. " +
+          "eg.) \"dataSize:equals:1000\" for showing records having the value 
1000 for dataSize")

Review Comment:
   As a class can't have 2 fields of the same name, we won't encounter this at 
the same level of the hierarchy. If you mean something like this:
   ```
   { 
   name : <value>,
   acls: { type : <value>,
           name : <value>,
         }
   }
   ```
   Then we would be passing the option like this for the full name of the 
field: 
   `--filter="name:equals:xyz"` and 
   `--filter="acls.name:equals:xyz"`
   In the result, the full record will be shown (same as how a normal scan 
command without the filter is seen). 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to